Skip to content

Conversation

@CarolineDenis
Copy link
Contributor

Fixes #5349

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • go in schema config
  • choose age table
  • try to add uniqueness rule

@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Oct 31, 2024
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • go in schema config
  • choose age table
  • try to add uniqueness rule

Works for all absolute and relative age tables 👍👍👍

@CarolineDenis CarolineDenis requested a review from a team October 31, 2024 15:16
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • go in schema config

  • choose age table

  • try to add uniqueness rule

Works for both age tables!

Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • go in schema config
  • choose age table
  • try to add uniqueness rule

Looks good!! Works as expected.

@CarolineDenis CarolineDenis removed the request for review from melton-jason October 31, 2024 17:39
@CarolineDenis CarolineDenis removed the request for review from acwhite211 October 31, 2024 18:24
@CarolineDenis CarolineDenis merged commit 3b475d8 into production Oct 31, 2024
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-5349-c branch October 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

All ages tables throw error when opening uniqueness rules in Schema Config

6 participants