Skip to content

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Aug 21, 2024

Fixes #5154

Table Aggregation Separators should no longer be getting set to undefined during serialization if they match the default ("; ").

All previously affected databases will need to have their separators restored separately. Though it is safe to assume all blanks were originally "; ".

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Go to App Resources -> Record Formatters -> and open any Table Aggregation
  • Set the separator to "; "
  • Save
  • Verify the separator is still there and isn't blank.

@alesan99 alesan99 marked this pull request as ready for review August 26, 2024 14:14
@alesan99 alesan99 requested review from a team August 26, 2024 14:14
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify the separator is still there and isn't blank.

Working as expected. Good job!

edge

Screen.Recording.2024-08-26.at.1.33.59.PM.mov

pr

Screen.Recording.2024-08-26.at.1.58.08.PM.mov

@pashiav pashiav requested a review from a team August 26, 2024 19:30
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to App Resources -> Record Formatters -> and open any Table Aggregation
  • Set the separator to "; "
  • Save
  • Verify the separator is still there and isn't blank.

Separator gets retained now, nice job!
Screenshot 2024-08-26 at 4 21 14 PM

@Areyes42 Areyes42 requested a review from a team August 26, 2024 21:23
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grantfitzsimmons grantfitzsimmons requested a review from a team August 26, 2024 23:49
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Go to App Resources -> Record Formatters -> and open any Table Aggregation
  • Set the separator to "; "
  • Save
  • Verify the separator is still there and isn't blank.

Looks good, separator doesn't get deleted

@alesan99 alesan99 merged commit f58f0d4 into production Aug 28, 2024
@alesan99 alesan99 deleted the issue-5154 branch August 28, 2024 12:59
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to DataObjFormatters

8 participants