-
Notifications
You must be signed in to change notification settings - Fork 41
Fix Table Aggregation Separator being set to undefined if it matches default "; " #5240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verify the separator is still there and isn't blank.
Working as expected. Good job!
edge
Screen.Recording.2024-08-26.at.1.33.59.PM.mov
pr
Screen.Recording.2024-08-26.at.1.58.08.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Go to App Resources -> Record Formatters -> and open any Table Aggregation
- Set the separator to "; "
- Save
- Verify the separator is still there and isn't blank.
Looks good, separator doesn't get deleted
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |

Fixes #5154
Table Aggregation Separators should no longer be getting set to undefined during serialization if they match the default ("; ").
All previously affected databases will need to have their separators restored separately. Though it is safe to assume all blanks were originally "; ".
Checklist
and self-explanatory (or properly documented)
Testing instructions