`xml-editor`: Attachment gallery button should not display unless there are attachments

[grantfitzsimmons]

Added in #3363

I believe it appears out of place and lacks usefulness without attachments. It does not align with the form meta menu button and lacks functionality without attachments already uploaded.

[CarolineDenis]

@grantfitzsimmons , Since attachments can take some time to be loaded it was decided to disable the button rather than remove it and then add it if there is attachments.
Plus, when we have a big number of records, by example 1200 we will only fetch the first X attachments and it might return an empty array, a dialog will than open when clicking on the gallery icon to fetch the next X. This would be possible neither if we remove the icon.
I suggest that we keep the button as it is

[maxpatiiuk]

Plus, when we have a big number of records, by example 1200 we will only fetch the first X attachments and it might return an empty array, a dialog will than open when clicking on the gallery icon to fetch the next X. This would be possible neither if we remove the icon.

that is the case in record sets. but the screenshot that Grant sent is not from a record set, it's from individual record

[CarolineDenis]

Well, I believe the issue at hand is that we currently have the attachments gallery icon present in the record set. However, we find ourselves in a new data entry form within a fictive record set. In order to address this, it would be advisable to remove the icon specifically for the fictive record set.