Fix Pyright errors #605
Open
Fix Pyright errors #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces very few type annotations, mostly erasing types, to avoid all errors reported by Pyright.
The goal is to get rid of type-related linting errors, while not losing any documentation tooltips etc. and without dumping tons of type annotations onto the codebase.
Especially, this does not import anything from
typingand it should cause very little cognitive overhead for readers of the code who are not familiar with Python's type annotations.More specific type definitions can be added later on a case-by-case basis, if needed.