Support Net::HTTP::Persistent.write_timeout

.github/workflows/ci-test.yml → .github/workflows/ci.yml

@@ -1,6 +1,13 @@
 name: "ci"
 
+concurrency:
+  group: "${{github.workflow}}-${{github.ref}}"
+  cancel-in-progress: true
+
 on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 8 * * 5" # At 08:00 on Friday # https://crontab.guru/#0_8_*_*_5
   push:
     branches:
       - main
@@ -13,10 +20,10 @@ jobs:
   rubocop:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: "3.0"
+        ruby-version: "3.3"
         bundler-cache: true
     - run: bundle exec rake rubocop
 
@@ -25,29 +32,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ["2.5", "2.6", "2.7", "3.0", "jruby", "truffleruby-head"]
-
+        ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "3.4", "head"]
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{matrix.ruby-version}}
         bundler-cache: true
     - run: bundle exec rake test
-
-  test-platform:
-    needs: ["rubocop"]
-    strategy:
-      fail-fast: false
-      matrix:
-        platform: ["windows-latest", "macos-latest"]
-
-    runs-on: ${{matrix.platform}}
-    steps:
-    - uses: actions/checkout@v2
-    - uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: "3.0"
-        bundler-cache: true
-    - run: bundle exec rake test

.github/workflows/upstream.yml

@@ -0,0 +1,51 @@
+name: "upstream"
+
+concurrency:
+  group: "${{github.workflow}}-${{github.ref}}"
+  cancel-in-progress: true
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 8 * * 5" # At 08:00 on Friday # https://crontab.guru/#0_8_*_*_5
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize]
+    branches:
+      - main
+    paths:
+      - .github/workflows/upstream.yml # this file
+
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby-version: ["head"]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{matrix.ruby-version}}
+          bundler-cache: true
+      - run: bundle exec rake test
+
+  upstream:
+    name: "upstream (${{matrix.name}})"
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - { name: "nokogiri", git: "https://github.com/sparklemotion/nokogiri" }
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with: { ruby-version: "3.4" }
+      - run: |
+          bundle add ${{matrix.name}} --git="${{matrix.git}}"
+          bundle show
+      - run: bundle exec rake test

CHANGELOG.md

@@ -1,5 +1,92 @@
 # Mechanize CHANGELOG
 
+## next / unreleased
+
+* `Mechanize` exposes a `write_timeout` attribute, which is set on the connection if it's supported (e.g., Net::HTTP::Persistent.write_timeout). (#586) @maurycy
+
+
+## 2.13.0 / 2025-01-02
+
+* Quash frozen string warnings in Ruby 3.4. (#661) @simpl1g
+* Quash URI::Parser warnings in Ruby 3.4. (#662) @flavorjones
+
+
+## 2.12.2 / 2023-10-02
+
+* Quash warnings from `Mime::Type.new` in `mime-types` v3.6.0. (#655) @avk
+
+
+## 2.12.1 / 2024-08-21
+
+* Introduce experimental support for handling Zstd-compressed responses (CRuby only). (#652) @adrianodennanni
+
+
+## 2.12.0 / 2024-07-29
+
+* Introduce experimental support for handling Brotli-compressed responses (CRuby only). (#650) @weshatheleopard
+
+
+## 2.11.0 / 2024-07-18
+
+* The `accept-charset` header is no longer sent. In early versions of Mechanize, circa 2007, this was a common header but now no modern browser sends it, and servers are instructed to ignore it. See #646 for an example of a server that is confused by its presence. (#647) @flavorjones
+
+
+## 2.10.1 / 2024-06-12
+
+* Improve page encoding error recovery on pages with broken encoding when used with libxml2 >= 2.12.0. (#644) @flavorjones
+
+
+## 2.10.0 / 2024-01-22
+
+* Add `nkf` and `base64` as explicit dependencies, since they are being unbundled in Ruby 3.4. (#634) @flavorjones
+
+
+## 2.9.2 / 2024-01-15
+
+* Correct spelling errors in documentation. (#631) @p-linnane
+* Updated User-Agent strings to represent modern browser versions. (#632) @takatea
+
+
+## 2.9.1 / 2023-04-17
+
+### Update
+
+* Updated User-Agent strings to represent modern browser versions. (#612) Thank you, @takatea!
+
+
+## 2.9.0 / 2023-04-07
+
+### Requirements
+
+* Mechanize now requires Ruby 2.6 or newer.
+
+
+### Improvement
+
+* Mechanize can now parse frozen strings. (#610)
+
+
+## 2.8.5 / 2022-06-09
+
+### Security
+
+Fixes low-severity CVE-2022-31033, "Authorization header leak on port redirect." See [GHSA-64qm-hrgp-pgr9](https://github.com/sparklemotion/mechanize/security/advisories/GHSA-64qm-hrgp-pgr9) for more details.
+
+
+## 2.8.4 / 2022-01-17
+
+### Fix
+
+* `Mechanize::CookieJar#load` calls `Psych.safe_load` when using Psych >= 3.1
+
+
+## 2.8.3 / 2021-11-11
+
+### Update
+
+* Update the "Linux Firefox" user agent string to rev94 (#587) Thank you, @ncs1!
+
+
 ## 2.8.2 / 2021-08-06
 
 ### Dependencies
@@ -69,7 +156,7 @@
   * Fix element(s)_with(search: selector) methods not working for forms, form fields and frames. (#444)
   * Improve the filename parser for the `Content-Disposition` header. (#496, #517)
   * Accept `Content-Encoding: identity`. (#515)
-  * Mechanize::Page#title no longer picks a title in an embeded SVG/RDF element. (#503)
+  * Mechanize::Page#title no longer picks a title in an embedded SVG/RDF element. (#503)
   * Make Mechanize::Form#has_field? boolean. (#501)
 
 ## 2.7.5
@@ -375,8 +462,8 @@
   * When given multiple HTTP authentication options mechanize now picks the
     strongest method.
   * Improvements to HTTP authorization:
-    * mechanize raises Mechanize::UnathorizedError for 401 responses which is
-      a sublcass of Mechanize::ResponseCodeError.
+    * mechanize raises Mechanize::UnauthorizedError for 401 responses which is
+      a subclass of Mechanize::ResponseCodeError.
     * Added support for NTLM authentication, but this has not been tested.
   * Mechanize::Cookie.new accepts attributes in a hash.
   * Mechanize::CookieJar#<<(cookie) (alias: add!) is added.  Issue #139
@@ -467,7 +554,7 @@ Mechanize is now under the MIT license
 
 * New Features
 
-  * Add header reference methods to Mechanize::File so that a reponse
+  * Add header reference methods to Mechanize::File so that a response
     object gets compatible with Net::HTTPResponse.
   * Mechanize#click accepts a regexp or string to click a button/link in the
     current page. It works as expected when not passed a string or regexp.
@@ -692,7 +779,7 @@ Mechanize is now under the MIT license
     http://d.hatena.ne.jp/kitamomonga/20080410/ruby_mechanize_percent_url_bug
   * #21132 Not checking for EOF errors on redirect
   * Fixed a weird gzipping error.
-  * #21233 Smarter multipart boundry. Thanks Todd Willey!
+  * #21233 Smarter multipart boundary. Thanks Todd Willey!
   * #20097 Supporting meta tag cookies.
 
 ## 0.7.6
@@ -801,7 +888,7 @@ Mechanize is now under the MIT license
 * [#9877] Moved last request time.  Thanks Max Stepanov
 * Added WWW::Mechanize::File#save
 * Defaulting file name to URI or Content-Disposition
-* Updating compatability with hpricot
+* Updating compatibility with hpricot
 * Added more unit tests
 
 ## 0.6.7
@@ -813,7 +900,7 @@ Mechanize is now under the MIT license
 
 * Removing hpricot overrides
 * Fixed a bug where alt text can be nil.  Thanks Yannick!
-* Unparseable expiration dates in cookies are now treated as session cookies
+* Unparsable expiration dates in cookies are now treated as session cookies
 * Caching connections
 * Requests now default to keep alive
 * [#9434] Fixed bug where html entities weren't decoded
@@ -879,7 +966,7 @@ Mechanize is now under the MIT license
 * Added a method to Form called "submit".  Now forms can be submitted by
   calling a method on the form.
 * Added a click method to links
-* Added an REXML pluggable parser for backwards compatability.  To use it,
+* Added an REXML pluggable parser for backwards compatibility.  To use it,
   just do this:
    agent.pluggable_parser.html = WWW::Mechanize::REXMLPage
 * Fixed a bug with referrers by adding a page attribute to forms and links.
@@ -1006,7 +1093,7 @@ Mechanize is now under the MIT license
 
 ## 0.4.4
 
-* Fixed error in method signature, basic_authetication is now basic_auth
+* Fixed error in method signature, basic_authentication is now basic_auth
 * Fixed bug with encoding names in file uploads (Big thanks to Alex Young)
 * Added options to the select list
 

Gemfile

@@ -1,3 +1,12 @@
 source "https://rubygems.org"
 
 gemspec
+
+gem "minitest", "~> 5.14"
+gem "rake", "~> 13.0"
+gem "rdoc", "~> 6.3"
+gem "rubocop", "~> 1.12"
+unless RUBY_PLATFORM == 'java'
+  gem 'brotli', '>= 0.5'
+  gem 'zstd-ruby', '~> 1.5'
+end

README.md

@@ -3,7 +3,7 @@
 * https://www.rubydoc.info/gems/mechanize/
 * https://github.com/sparklemotion/mechanize
 
-[![Test suite](https://github.com/sparklemotion/mechanize/actions/workflows/ci-test.yml/badge.svg)](https://github.com/sparklemotion/mechanize/actions/workflows/ci-test.yml)
+[![Test suite](https://github.com/sparklemotion/mechanize/actions/workflows/ci.yml/badge.svg)](https://github.com/sparklemotion/mechanize/actions/workflows/ci.yml)
 
 
 ## Description
@@ -13,7 +13,7 @@ The Mechanize library is used for automating interaction with websites. Mechaniz
 
 ## Dependencies
 
-* Ruby >= 2.5
+* Ruby >= 2.6
 * Gems:
   * `addressable`
   * `domain_name`

Rakefile

@@ -49,7 +49,7 @@ namespace "rubocop" do
 
   desc "Run rubocop string literals check"
   task :frozen_string_literals do
-    sh "rubocop lib --auto-correct-all --only Style/FrozenStringLiteralComment"
+    sh "rubocop lib test --auto-correct-all --only Style/FrozenStringLiteralComment"
   end
 end