Enahancement: As a user user I need to change the segment mapping for an existing character #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge B define char branch into master
Fixed colon and decimal positions in code
This reverts commit 83a71a2.
|
Hey @fourstix. I'm working to merge your pull request. Can you please change the version number in library.properties to 1.1.1 so that I can do a release once merged? |
|
@pmakin-png I updated the version to 1.1.1 as requested. So you should be able to do the merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the character map into PROGMEM and adds previously missing characters to the table to simplify the map logic.
A function is added to define a character segment map to a list. The list is checked before a character is displayed from the default character map table. An example is provided to show the use of this function.
Lastly, a previous stray debug serial print statement is commented out, and the period and colon characters are changed to blanks so the display is not corrupted when the fixed decimal point or colon is displayed.
All previous examples were run as a regression test.