Change set...StatustoInt to read-modify-write #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks great. I tested out the second example and found that the setPinMode did not work as intended and so I included it in this pull request since this one essentially fixes the interrupt functions overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setAccelStatustoInt1callsism330dhcx_pin_int1_route_setwhich, in turn, writes to multiple registers (seven in total).The
ism330dhcx_pin_int1_route_tstruct wasn't being initialized causingsetAccelStatustoInt1to write mostly garbage into the registers...This PR changes all four functions to read-modify-write, to ensure the
ism330dhcx_pin_int1_route_tis 'clean' and that only the desired routing bit is changed. It also allows the routing bit to be cleared again, by settingenableparameter to false.