Skip to content

Conversation

@PaulZC
Copy link
Contributor

@PaulZC PaulZC commented Sep 4, 2022

This PR:

  • Includes changes to let the code compile cleanly on ESP32 v2.0.4
  • Corrects the default bit ordering (MSBFIRST) for SPI

@PaulZC PaulZC requested a review from edspark September 4, 2022 23:20
@edspark
Copy link
Collaborator

edspark commented Sep 7, 2022

Thank you Paul, I tested the changes and everything worked great. I shared an issue I had with Artemis modules and the bit order, but that 'issue' is not an 'issue' it seems.

@edspark edspark merged commit 04eea67 into main Sep 7, 2022
@PaulZC PaulZC deleted the ESP32_v2.0.4_Fixes branch September 7, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants