Clear PCI at end of byte #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug receiving non-visable ASCII.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that corrupts non-visible ASCII.
Notes:
The Pin Change Interrupt was firing after the compare interrupt (completion of byte) which was causing the incorrect start of a new byte. PCI is now cleared at the end of Compare. In the future, we could change the PCI from CHANGE to FALLING to be more sure that we're seeing the start of a new byte but it's not a guarantee. And this PR works.
This was found while connecting the Artemis to the LTE shield using software serial. Lots of \n and \r's in the AT command flows that were getting corrupt. This fixes those corruptions.