Small fixes #432
Merged
Small fixes #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only include officially supported CMake base build for end users - Of course this includes the "easy mode" shell script that wraps CMake - Exclude the src/gasnet dir from release archives because MPI is the current official backend. Only advanced users should try the gasnet version which is probably quite stale.
- OpenCoarrays can be demoed in the cloud using binder. - See https://github.com/sourceryinstitute/jupyter-CAF-kernel for details
|
LGTM documentation changes only.
|
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
=======================================
Coverage 39.38% 39.38%
=======================================
Files 3 3
Lines 2105 2105
Branches 350 350
=======================================
Hits 829 829
Misses 1154 1154
Partials 122 122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Rationale for changes
Save users from themselves & allow users to try OpenCoarrays in the cloud w/ zero setup/config etc
Additional info and certifications
This pull request (PR) is a:
I certify that
- Increasing test coverage for all feature-addition PRs
- Increasing test coverage for all bug-fix PRs for which there
does not already exist a related test that failed before the PR
- At least maintaining test coverage for all other PRs
- Ensuring that all tests pass when run locally
- Naming PR to indicate work in progress (WIP) and to attach the PR
to the appropriate bug report or feature request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the PR to give another
OpenCoarrays developer a chance to review my proposed code