Fix sync images to take the syncer's id from mpi_status. #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take the source index of the image that is sending the current image data from the MPI_status handle of Waitany instead of the index i, which only denotes the handle in the array of receive-requests.
|
Great! 💯 Assuming that the tests indicate that this has been resolved, it looks good to me! Once the tests pass, I will merge this ASAP |
Merged
Current coverage is 45.33% (diff: 0.00%)@@ master #313 diff @@
==========================================
Files 2 3 +1
Lines 903 1019 +116
Methods 43 64 +21
Messages 0 0
Branches 191 193 +2
==========================================
+ Hits 456 462 +6
- Misses 367 479 +112
+ Partials 80 78 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the source index of the image that is sending the current image data from
the MPI_status handle of Waitany instead of the index i, which only denotes the
handle in the array of receive-requests.
Fixes #302