UPGRADE lodash to latest, #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX problems arisen from the upgrade, But eslint is not able to lint because of `TypeError: Cannot read property 'visitClass' of undefined`. Seems to be unrelated to the upgrade of lodash. Mocha tests are passing
|
Tests still failing. I would wait with upgrading those deps until we merge latest changes from styleguidist. |
|
Done in #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX problems arisen from the upgrade,
But eslint is not able to lint because of
TypeError: Cannot read property 'visitClass' of undefined. Seems to be unrelated to the upgrade of lodash.Mocha tests are passing
Should there be a dev branch to PR to?