Add semgrep CI scan step #1177
Merged
Add semgrep CI scan step #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evict
reviewed
Jun 24, 2025
Comment on lines
+14
to
+15
| container: | ||
| image: returntocorp/semgrep |
There was a problem hiding this comment.
Just a copypasta from our other semgrep.ymls. Looks like GHA uses :latest by default. We should probably pin to a specific version, but will need to do that everywhere.
There was a problem hiding this comment.
but will need to do that everywhere
we can start here, hehe.
There was a problem hiding this comment.
We also need to overhaul all our SAST, i'll leave it with @andreeleuterio 😉
evict
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SAST scanning as part of SEC-3159
Test plan
Check scan succeeds