Skip to content

fix go-generate command in goreleaser config #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

craigfurman
Copy link
Contributor

golang/go#60079 changed the behavior of go-generate when the target package does not exist. It used to silently succeeed, now it errors. The schema package was removed in 2021.

Test plan

Manually ran go generate.

golang/go#60079 changed the behavior of
go-generate when the target package does not exist. It used to silently
succeeed, now it errors. The schema package was removed in 2021.
@craigfurman craigfurman requested a review from a team as a code owner May 15, 2024 14:45
Copy link
Contributor

@BolajiOlajide BolajiOlajide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ty:

@craigfurman craigfurman merged commit f8ab447 into main May 15, 2024
@craigfurman craigfurman deleted the fix-go-generate branch May 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants