-
Notifications
You must be signed in to change notification settings - Fork 132
feat(ask_sb): Add back search scope requirement and other UI changes #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change reintroduces the requirement for selecting a search scope in the "ask sb" feature, updating UI components and control flow to enforce and communicate this constraint. It also adds visual and usability enhancements to related components, including improved filter badges, icons, and contextual documentation links. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ChatBox
participant ParentComponent
User->>ChatBox: Attempt to submit (with no search scope)
ChatBox-->>User: Show tooltip and toast warning
ChatBox-->>ParentComponent: onContextSelectorOpenChanged(true)
User->>ChatBox: Select search scope(s)
ChatBox-->>User: Enable submit
User->>ChatBox: Submit question
ChatBox-->>ParentComponent: onContextSelectorOpenChanged(false)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15–20 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
🧰 Additional context used📓 Path-based instructions (1)**/*📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Files:
🧬 Code Graph Analysis (2)packages/web/src/app/[domain]/components/homepage/askSourcebotDemoCards.tsx (2)
packages/web/src/features/chat/components/chatBox/chatBox.tsx (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (27)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Select all
option in search scope selectorSummary by CodeRabbit
New Features
Enhancements
UI Updates
Documentation