Skip to content

Conversation

geshuming
Copy link
Contributor

This is a re-pull request since the other branch was badly done.

Changes:

  • Changed from Output[] to Summary output format
  • Refactored for new XML format

Todo:

  • Rewrite tests to only test autograder and not library files

@geshuming geshuming requested a review from yyc April 16, 2019 14:14
@geshuming geshuming mentioned this pull request Apr 16, 2019
@coveralls
Copy link

coveralls commented Apr 16, 2019

Pull Request Test Coverage Report for Build 211

  • 39 of 39 (100.0%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 35.073%

Files with Coverage Reduction New Missed Lines %
src/graphics/curves_library.js 12 70.22%
Totals Coverage Status
Change from base Build 156: -0.1%
Covered Lines: 1044
Relevant Lines: 2918

💛 - Coveralls

@geshuming geshuming force-pushed the refactor-grader-v2 branch from f239374 to d4598b9 Compare April 16, 2019 14:32
Copy link
Collaborator

@yyc yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor issues in the comments, fix those and it should be good to go.

@geshuming geshuming requested a review from yyc May 11, 2019 07:10
@geshuming geshuming changed the title Refactored Autograder v2 Integrate 1920 Source Format and Refactor Grader May 16, 2019
Copy link
Collaborator

@yyc yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yyc yyc merged commit 9d67cb6 into source-academy:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants