Skip to content

Conversation

RichDom2185
Copy link
Member

Description

No BE change required.

Adds resizable columns, filter by name, username, group.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Aug 19, 2024
@RichDom2185 RichDom2185 requested a review from sayomaki August 19, 2024 10:43
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10452155580

Details

  • 0 of 11 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 31.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/grading/subcomponents/GradingSubmissionsTable.tsx 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/grading/subcomponents/GradingSubmissionsTable.tsx 1 2.87%
Totals Coverage Status
Change from base Build 10450727526: -0.02%
Covered Lines: 4851
Relevant Lines: 14542

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the logging part, but otherwise the code looks great!

@RichDom2185 RichDom2185 enabled auto-merge (squash) August 19, 2024 11:05
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants