Skip to content

Improve seeding feature for grading related tables #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Mar 21, 2024
Merged

Improve seeding feature for grading related tables #1067

merged 43 commits into from
Mar 21, 2024

Conversation

GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Feb 19, 2024 •
edited
Loading

To be merged after #1065

  • Seed now finds if Test Admin exists and will allocate admin to be group leader
  • Implement ability to change number of students and assessments per student for seeding
  • Change code to only create 3 types of assessments (Missions, Paths and Quests)
  • Assessments now have fixed structures depending on assessment type, mimicing CS1101S where Paths tend to be MCQ only while Missions and Quests are programming questions.

@GabrielCWT
feat: implement paginated submissions query function
29246b0
@GabrielCWT
feat: implement /grading route accepting pagination query parameters
a60e39f
@GabrielCWT
fix: fix paginated submissions with group filter
29057e7 
* Changed group_filter query to work with the new paginated query
@GabrielCWT
refactor: change page to offset for pagination
c662fbc
@GabrielCWT
feat: Update admin grading controller to take variable amount of params
6adbf8c
@GabrielCWT
refactor: Refactor code from using raw sql to using ecto query
3b621af
@GabrielCWT
feat: Implement filtering by mission name
fc55c55
@GabrielCWT
feat: Implement filtering by progress for submission
610ffbf
@GabrielCWT
refactor: show all and show only grader's groups now use ecto query
7de9882
@GabrielCWT
feat: Implement filter by group id
c9ba93e
@GabrielCWT
fix: Fix limit and offset default for missing query param
451cea8
@GabrielCWT
refactor: Rename group filter to course registration filter
940e282
@GabrielCWT
feat: Implement filter by name
2f5c910
@GabrielCWT
feat: Implement filter by assessment type
ca768aa
@GabrielCWT
Implement filter by is_manually_graded
9ff4108
@GabrielCWT
feat: Include total count of submissions in response
8afcc22
@GabrielCWT
refactor: Use one join query for assessment config queries
c7dc2ca
@GabrielCWT
refactor: Use one join query for user queries
2e9b1ea
@GabrielCWT
refactor: Move queries for assessment and assessment config to builder
70b7f59
@GabrielCWT
fix: Update admin_grading_controller test to account for change in re…
f5f651d 
…sponse
@GabrielCWT
refactor: Rename function
37c7a4e
@GabrielCWT
docs: Include a description of the function
b7ea15b
@GabrielCWT
refactor: Format code
0fd3e65
@GabrielCWT
Merge branch 'master' into gabriel/pagination
bac36b4
@GabrielCWT
fix: Update filter by groupID to groupName
00e48f2
@GabrielCWT
feat: Assessment title filter using LIKE
80e2f5e
@GabrielCWT
fix: Change Notification/Email tests to use the new response
b1a249c
@GabrielCWT
refactor: Remove old code for submissions query
82b2a10
@GabrielCWT
feat: Implement new seed for populating DB
22b05f9
@GabrielCWT
refactor: Make only 3 types of assessments (Mission, Path, Quest)
013893e
@coveralls
Copy link

coveralls commented Feb 19, 2024 •
edited
Loading

Coverage Status

coverage: 95.31%. remained the same
when pulling ca24523 on GabrielCWT:feat/seeding
into 8208743 on source-academy:master.

@GabrielCWT GabrielCWT marked this pull request as ready for review February 24, 2024 04:36
RichDom2185
RichDom2185 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot! The increased diversity in seed data will greatly improve the development experience 😄

@RichDom2185 RichDom2185 enabled auto-merge (squash) March 21, 2024 11:39
@RichDom2185 RichDom2185 merged commit 5975023 into source-academy:master Mar 21, 2024
@GabrielCWT GabrielCWT deleted the feat/seeding branch March 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GabrielCWT @coveralls @RichDom2185 @josh1248