Skip to content

Add optional error message on authentication fail #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add optional error message on authentication fail #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type service struct {
type Server struct {
config Config
services []service
AuthFunc func(Credential, *Request) (bool, error)
AuthFunc func(Credential, *Request) (bool, string, error)
}

type Request struct {
Expand Down Expand Up @@ -103,14 +103,17 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
return
}

allow, err := s.AuthFunc(cred, req)
allow, msg, err := s.AuthFunc(cred, req)
if !allow || err != nil {
if err != nil {
logError("auth", err)
}

logError("auth", fmt.Errorf("rejected user %s", cred.Username))
w.WriteHeader(http.StatusUnauthorized)
if msg != "" {
w.Write([]byte(msg))
}
return
}
}
Expand Down