Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Event Time "et": add non measurement protocol parameter #2

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Event Time "et": add non measurement protocol parameter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,3 +184,6 @@ $RECYCLE.BIN/
# Roslyn VS2015 junk
*.sln.ide/
*.nupkg

# Visual Studio temp and user data
*/.vs/
4 changes: 2 additions & 2 deletions Source/CSharpAnalytics.Tests/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[assembly: AssemblyProduct("CSharpAnalytics")]
[assembly: AssemblyCopyright("Copyright © 2012-2014 Attack Pattern LLC.")]

[assembly: AssemblyVersion("1.4.0.0")]
[assembly: AssemblyFileVersion("1.4.0.0")]
[assembly: AssemblyVersion("1.5.0.0")]
[assembly: AssemblyFileVersion("1.5.0.0")]
[assembly: AssemblyDescriptionAttribute("Unit tests for CSharpAnalytics")]
[assembly: NeutralResourcesLanguageAttribute("")]
3 changes: 2 additions & 1 deletion Source/CSharpAnalytics.Tests/Protocols/Measurement/MeasurementAnalyticsClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,14 @@ public void MeasurementAnalyticsClient_SetCustomMetric_Decimal_Is_Sent()
}

[TestMethod]
public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Adds_Qt_Parameter()
public void MeasurementAnalyticsClient_AdjustUriBeforeRequest_Adds_TimeStamp_Parameters()
{
var originalUri = new Uri("http://anything.really.com/something#" + DateTime.UtcNow.ToString("o"));

var actual = new MeasurementAnalyticsClient().AdjustUriBeforeRequest(originalUri);

StringAssert.Contains(actual.Query, "qt=");
StringAssert.Contains(actual.Query, "et=");
}

[TestMethod]
Expand Down
4 changes: 2 additions & 2 deletions Source/CSharpAnalytics/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
[assembly: AssemblyProduct("CSharpAnalytics")]
[assembly: AssemblyCopyright("Copyright © 2012-2014 Attack Pattern LLC.")]

[assembly: AssemblyVersion("1.4.0.0")]
[assembly: AssemblyFileVersion("1.4.0.0")]
[assembly: AssemblyVersion("1.5.0.0")]
[assembly: AssemblyFileVersion("1.5.0.0")]
[assembly: ComVisible(false)]

[assembly: InternalsVisibleTo("CSharpAnalytics.Test.Net45")]
Expand Down
3 changes: 3 additions & 0 deletions Source/CSharpAnalytics/Protocols/Measurement/MeasurementAnalyticsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,9 @@ private static void AddQueueTimeFromFragment(Uri uri, IDictionary<string, string
DateTime utcHitTime;
if (!DateTime.TryParse(decodedFragment, out utcHitTime)) return;

//Event Time "et": add non measurement protocol parameter, can be used by a server side dispatcher to re-adjust "qt"
parameters["et"] = utcHitTime.ToString("O");

var queueTime = DateTimeOffset.Now.Subtract(utcHitTime);
if (queueTime.TotalMilliseconds < 0) return;

Expand Down
4 changes: 2 additions & 2 deletions Source/Samples/CSharpAnalytics.Sample.WinForms/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
[assembly: AssemblyProduct("CSharpAnalytics")]
[assembly: AssemblyCopyright("Copyright © 2012-2014 Attack Pattern LLC.")]

[assembly: AssemblyVersion("1.4.0.0")]
[assembly: AssemblyFileVersion("1.4.0.0")]
[assembly: AssemblyVersion("1.5.0.0")]
[assembly: AssemblyFileVersion("1.5.0.0")]
[assembly: ComVisible(false)]