-
Notifications
You must be signed in to change notification settings - Fork 322
docs: add /guides/.../welcome route redirect -> /quick-start #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7ba4c90
to
8e0a8dd
Compare
Couldn't we just fix the link on the old docs instead of setting up a redirect here for the bad link? |
This would at least guarantee, if this link was in use somewhere else in the internet or in the SolidJS docs. I am happy to just change the href if you want to but I wasn't sure if this URL was used on somewhere else both in the docs or external web. |
I believe this can be put in the legacy redirect page - https://github.com/solidjs/solid-docs/blob/main/src/middleware/legacy-routes-redirect.ts |
Description (required)
Fix a broken link path that leads new users to a 404.
How I encountered it
- The “here” link points to
https://docs.solidjs.com/guides/tutorials/getting-started-with-solid/welcome
What this PR does
src/routes/guides/tutorials/getting-started-with-solid/welcome.tsx
/quick-start
(via standard WebResponse
withLocation
)window.location.replace
) for SPA navigationsTesting
pnpm dev
/guides/tutorials/getting-started-with-solid/welcome
redirects to/quick-start
Related issues & labels
documentation
,bug
,good first issue