Bundle all the project #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvictorio
force-pushed
the
bundle-parser
branch
from
c7cc91e to
f9bba29
Compare
1 task
|
Thanks @fvictorio Everything's running clean on my side. Looks good 💯 |
Contributor
Author
|
@cgewecke Thank you! I'll release a new version then 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
A huge list of changes here. But the tl;dr is: use rollup and typescript, and include
antlr4in the bundle because they set their node engines as>= 14, which causes issues for people using node<14that install this package with yarn.@cgewecke I published this as
@solidity-parser/parser@rc. Could you check if it works for you? I tested it in prettier-solidity and solhint, and in both cases I had introduced bugs (which I already fixed), so it wouldn't surprise me if I introduced a bug for one of your projects too 😅