Don't display incorrect SAM Economic Models ITC [v3.9.40] #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DO to extract from cash flow profile)
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
changed the title
softwareengineerprogrammer
merged commit 78711a3
into
redrilling-costs-fixup
36 checks passed
This was referenced Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround for NREL#404: skip displaying the ITC value for SAM Economic Models because it can be/probably is usually mathematically inaccurate, and even if it's not, it's redundant with the cash flow profile and also misleading/confusing/wrong to display it as a capital cost since it is not a capital expenditure.
For example
Fervo_Project_Cape-4displays ITC as$-688.54Mbut the probably-corresponding line item in cash flow is$791,817,681:Testing & Verification
Regenerated impacted example unit tests:
Fervo_Project_Cape-4,example_SAM-single-owner-PPA, &example_SAM-single-owner-PPA-2. Their results remain the same except for the removal of theInvestment Tax Creditoutput field.