Skip to content

Parameterize indirect costs [v3.9.34] #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Parameterize indirect costs [v3.9.34] #84

wants to merge 21 commits into from
+473 −271

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jul 22, 2025 •
edited
Loading

Description

  1. Parameterize indirect cost factor & contingency NREL/GEOPHIRES-X#383
  2. Schema Generator should be run automatically as pre-commit hook NREL/GEOPHIRES-X#379

Testing & Verification

  1. Existing behavior unchanged - relevant unit tests pass as-is
  2. Added stimulation indirect cost unit test
  3. Generated schemas test

@softwareengineerprogrammer softwareengineerprogrammer added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 22, 2025
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request Jul 22, 2025
Merged
@softwareengineerprogrammer
Enumerate categories that indirect cost is applied to. Specify stimul…
ca13f6a 
…ation per-well cost parameters are before indirect costs and contingency.
@softwareengineerprogrammer
Generated schemas test that functionally addresses NREL#379
9ad5d2a
@softwareengineerprogrammer
address py38-incompatible annotation introduced in previous commit (h…
1e9a036 
…ttps://github.com/softwareengineerprogrammer/GEOPHIRES/actions/runs/16475995168/job/46577644537?pr=84)
@softwareengineerprogrammer
import __future__ annotations in correct file (main.py instead of tes…
7f025d3 
…t_generated_schemas.py)
@softwareengineerprogrammer
Well Drilling and Completion Capital Cost more complete documentation…
1e617b9 
… in tooltip text
@softwareengineerprogrammer
Address new intermittent failure observed in GitHub Actions py311 mac…
bf0000c 
…os (https://github.com/softwareengineerprogrammer/GEOPHIRES/actions/runs/16476574734/job/46579711905)
@softwareengineerprogrammer
Break out Economics.calculate_wellfield_costs (no functional change)
e610fd0
@softwareengineerprogrammer
workaround intermittent failure now also occurring on py311 ubuntu (h…
12fab1a 
…ttps://github.com/softwareengineerprogrammer/GEOPHIRES/actions/runs/16477002832/job/46581220253)
@softwareengineerprogrammer
Root cause of intermittent failures may have been introduced in 9ad5d2a…
263bba2 
… due to schema generator adding log handlers. Address by reverting previous workaround strategy (bf0000c, 12fab1a), updating client _get_logger method to store loggers by name, and using it instead of an ad hoc implementation in the schema generator.
@softwareengineerprogrammer
Workaround in previous commit may have been partially successful, wor…
89d6bda 
…karound remaining intermittent failure in test_unsupported_econ_params_ignored_with_warning for now
@softwareengineerprogrammer
use presence of TOXPYTHON env var to determine if running in GitHub A…
5d30443 
…ctions
@softwareengineerprogrammer
wrap with self.assertLogs in try/except, not just self.assertHasLogRe…
71061e9 
…cordWithMessage (https://github.com/softwareengineerprogrammer/GEOPHIRES/actions/runs/16479502968/job/46589787461)
@softwareengineerprogrammer
apply workaround in test_discount_rate_and_fixed_internal_rate
5b41945
@softwareengineerprogrammer
Bump version: 3.9.33 → 3.9.34
698d913
@softwareengineerprogrammer softwareengineerprogrammer changed the title Parameterize indirect costs Parameterize indirect costs [v3.9.34] Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@softwareengineerprogrammer