Skip to content

Parameterize indirect costs [v3.9.34] #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 23, 2025

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jul 22, 2025

Description

  1. Parameterize indirect cost factor & contingency NREL/GEOPHIRES-X#383 (relevant to Standardize specific costs NREL/GEOPHIRES-X#400).
    1. Adds parameters:
      1. Indirect Capital Cost Percentage: "The indirect cost percentage applied to capital costs (default 12%). This value is used for all cost categories including surface plant, field gathering system, and exploration except when a category-specific indirect cost parameter is defined or provided. Wellfield costs use Well Drilling and Completion Indirect Capital Cost Percentage (default 5%). Stimulation costs use Reservoir Stimulation Indirect Capital Cost Percentage (default 5%)."
      2. Reservoir Stimulation Indirect Capital Cost Percentage: "The indirect capital cost for reservoir stimulation, calculated as a percentage of the direct cost. (Not applied if Reservoir Stimulation Capital Cost is provided.)"
      3. Well Drilling and Completion Indirect Capital Cost Percentage: Well drilling and completion capital cost per well including indirect costs and contingency. Applied to production wells; also applied to injection wells unless Injection Well Drilling and Completion Capital Cost is provided.
    2. Documents application of indirect and contingency costs, and other tangentially relevant costing behavior, for:
      1. Reservoir Stimulation Capital Cost: "Total reservoir stimulation capital cost, including contingency and indirect costs."
      2. Reservoir Stimulation Capital Cost per Injection Well: "Reservoir stimulation capital cost per injection well before indirect costs and contingency"
      3. Reservoir Stimulation Capital Cost per Production Well: "Reservoir stimulation capital cost per production well before indirect costs and contingency. By default, only the injection wells are assumed to be stimulated unless this parameter is provided."
      4. Well Drilling and Completion Capital Cost: "Well drilling and completion capital cost per well including indirect costs and contingency. Applied to production wells; also applied to injection wells unless Injection Well Drilling and Completion Capital Cost is provided. "
  2. Schema Generator should be run automatically as pre-commit hook NREL/GEOPHIRES-X#379. Note: the addition of this test appears to have triggered a latent test configuration and/or associated race condition issue that occurs intermittently in GitHub Actions. This PR includes a number of trial-and-error commits that both partially address and work around this issue.

Testing & Verification

  1. Existing behavior unchanged - relevant unit tests such as test_geophires_examples pass as-is
  2. Added indirect costs unit test
  3. Generated schemas test
  4. Web interface: image

…ation per-well cost parameters are before indirect costs and contingency.
… due to schema generator adding log handlers. Address by reverting previous workaround strategy (bf0000c, 12fab1a), updating client _get_logger method to store loggers by name, and using it instead of an ad hoc implementation in the schema generator.
…karound remaining intermittent failure in test_unsupported_econ_params_ignored_with_warning for now
@softwareengineerprogrammer softwareengineerprogrammer changed the title Parameterize indirect costs Parameterize indirect costs [v3.9.34] Jul 23, 2025
@softwareengineerprogrammer softwareengineerprogrammer merged commit 16dd1a1 into main Jul 23, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant