Skip to content

Conversation

@wtn
Copy link
Contributor

@wtn wtn commented Sep 14, 2025

While using Ruby 3.3.9, I saw the following warning:

% bundle exec rake test
…/protocol-http-0.53.0/lib/protocol/http/header/accept.rb:84:
warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

Types of Changes

  • Maintenance.

Contribution

@wtn wtn changed the title Adjust parentheses after >> method name. Adjust parentheses after << method name. Sep 14, 2025
@ioquatix
Copy link
Member

In other parts of the code we use def << value. Is that also problematic?

@wtn
Copy link
Contributor Author

wtn commented Sep 20, 2025

I think it's only this specific style that's problematic:

def << (arg)

So I've removed the parentheses from both definitions of #<< that had them, now it's consistent throughout.

@ioquatix ioquatix merged commit 4594793 into socketry:main Sep 20, 2025
18 of 20 checks passed
@wtn wtn deleted the warning branch September 20, 2025 01:49
@ioquatix
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants