Prefer 'close' over 'keep-alive' when both are present #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
handle-conflicting-connection-values
branch
from
f7761ed to
d0d03ca
Compare
ioquatix
force-pushed
the
handle-conflicting-connection-values
branch
from
d0d03ca to
8fc0885
Compare
ioquatix
approved these changes
Jan 26, 2024
Member
|
What an interesting behaviour. Apparently Chrome and Firefox interpret this differently. https://stackoverflow.com/questions/11443669/how-to-interpret-connection-keep-alive-close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Connectionheader has bothcloseandkeep-alive, both related methods return true despite the conflicting instructions.This PR changes
keep_alive?to return false ifcloseis simultaneously present.Related to socketry/async-http#132
Types of Changes
Contribution