-
-
Notifications
You must be signed in to change notification settings - Fork 21
Etags: add strong and weak matchers #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Before we merge this, can you please run |
|
|
|
Ohhh, yes, |
|
Alright, I think we're ready? |
lib/protocol/http/header/etags.rb
Outdated
|
|
||
| # Released under the MIT License. | ||
| # Copyright, 2020-2023, by Samuel Williams. | ||
| # Copyright, 2023, by thomas morgan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind making sure your git user name has appropriate capitalisation? The name for copyright is taken from the history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really up for changing my standard commit config, but it looks like I can update .mailmap for that (thanks for supporting such an option!) I'll get that done and pushed here shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also just change it per .git/config if that is easier. Either option is fine.
This adds
strong_match?andweak_match?methods to the Etags class for use with If-Match and If-None-Match.Arguably the existing
match?could become an alias toweak_match?, but it could be considered a backwards incompatible change so I've left it as-is. Happy to change if you think it's a good idea.Types of Changes
Contribution