Skip to content

Conversation

@zarqman
Copy link
Contributor

@zarqman zarqman commented Aug 23, 2023

This adds strong_match? and weak_match? methods to the Etags class for use with If-Match and If-None-Match.

Arguably the existing match? could become an alias to weak_match?, but it could be considered a backwards incompatible change so I've left it as-is. Happy to change if you think it's a good idea.

Types of Changes

  • New feature.

Contribution

@ioquatix
Copy link
Member

Before we merge this, can you please run bake modernize:license and make sure your name shows up correctly. Thanks!

@zarqman
Copy link
Contributor Author

zarqman commented Aug 24, 2023

bake modernize:license returns ArgumentError: Could not find recipe for modernize:license!. I tried bake list but don't see anything for modernize at all. Do I need to install or run something else first?

@ioquatix
Copy link
Member

Ohhh, yes, bundle config --local with maintenance followed by bundle install.

@zarqman
Copy link
Contributor Author

zarqman commented Aug 24, 2023

Alright, I think we're ready?


# Released under the MIT License.
# Copyright, 2020-2023, by Samuel Williams.
# Copyright, 2023, by thomas morgan.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind making sure your git user name has appropriate capitalisation? The name for copyright is taken from the history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really up for changing my standard commit config, but it looks like I can update .mailmap for that (thanks for supporting such an option!) I'll get that done and pushed here shortly.

Copy link
Member

@ioquatix ioquatix Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just change it per .git/config if that is easier. Either option is fine.

@ioquatix ioquatix merged commit 22ed925 into socketry:main Aug 25, 2023
@zarqman zarqman deleted the enhance-etags branch August 25, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants