Skip to content

Test with traces enabled. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Test with traces enabled. #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba222e
Test with traces enabled.
ioquatix Nov 10, 2022
2dda7c8
Fix external tests.
ioquatix Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion async-http.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "protocol-http", "~> 0.23.1"
spec.add_dependency "protocol-http1", "~> 0.14.0"
spec.add_dependency "protocol-http2", "~> 0.14.0"
spec.add_dependency "traces", ">= 0.4.0"
spec.add_dependency "traces", ">= 0.8.0"

spec.add_development_dependency "async-container", "~> 0.14"
spec.add_development_dependency "async-rspec", "~> 1.10"
Expand Down
2 changes: 1 addition & 1 deletion config/external.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ async-rest:
command: bundle exec rspec
async-websocket:
url: https://github.com/socketry/async-websocket.git
command: bundle exec rspec
command: bundle exec sus
async-http-faraday:
url: https://github.com/socketry/async-http-faraday.git
command: bundle exec rspec
Expand Down
2 changes: 1 addition & 1 deletion lib/async/http/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def call(request)
end

trace('async.http.client.call', attributes: attributes) do |span|
if context = trace_context(span)
if context = self.trace_context
request.headers['traceparent'] = context.to_s
# request.headers['tracestate'] = context.state
end
Expand Down
2 changes: 2 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

require 'async/rspec'

ENV['TRACES_BACKEND'] ||= 'traces/backend/test'

RSpec.shared_context 'docstring as description' do
let(:description) {self.class.metadata.fetch(:description_args).first}
end
Expand Down