fix: auth property on Socket is public
#1455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think, that the CI is failing because of this PR. |
darrachequesne
pushed a commit
that referenced
this pull request
Mar 31, 2021
|
Merged as c150223. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the
socket.io.jsfile is the generated output ofmake socket.io.js, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
Currently the
authproperty on theSocketobject is aprivateTypeScript property.In the docs, it says that we can change the
authproperty. (see: https://socket.io/docs/v3/client-initialization/#auth)But currently we can't in TypeScript.
New behaviour
Now the
authproperty ispublic, so we can update it.