Export TransportError #709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Currently
TransportErroris not exported, so if you want to check if an error is aTransportErrorin TypeScript witheslintyou need to do something like this:It's kind of a minor inconvenience, but many
eslintconfigs prohibit the use ofany, so it results in some extra boilerplate every time you need to do this check.New behaviour
By exporting
TransportErrorwe will be able to import the type and perform the check like this:It should also make it possible to use
instanceofinstead:error instanceof TransportError.Other information (e.g. related issues)
If this suggestion is accepted I'll make a follow-up PR to https://github.com/socketio/socket.io-client to export the type from there as well.