-
Notifications
You must be signed in to change notification settings - Fork 527
SNOW-439518 removing cloud sdks #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1909089 to
17b0f4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 82.58% 84.38% +1.79%
==========================================
Files 64 58 -6
Lines 9033 7728 -1305
Branches 1378 1129 -249
==========================================
- Hits 7460 6521 -939
+ Misses 1184 903 -281
+ Partials 389 304 -85
Continue to review full report at Codecov.
|
17b0f4c to
e13839c
Compare
e13839c to
e5b3a7c
Compare
e5b3a7c to
7edbddd
Compare
sfc-gh-jbahk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-439518
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Following up SNOW-300951 removing cloud SDKs #725 and actually removing the SDKs as dependencies.