Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Conversation

@UmerIftikhar
Copy link

@UmerIftikhar UmerIftikhar commented Sep 17, 2020

Info

This Pull Request is related to issue no. [6] ([https://github.com//issues/6])

Changes

  • Added Support for EFCore. (Project Name: Chronicle.Integrations.EFCore)
  • Added EFCoreTestAppWithChronicleSaga WebAPI Project which includes samples on implementing Saga using Chronicles Internal EFCore
  • In the EFCoreTestAppWithCutomSaga WebAPI Project also implemented a custom implementation of ISagaLog & ISagaStateRepository.
  • ReadMe updated to mention about EFCoreTestAppWithChronicleSaga & EFCoreTestAppWithCutomSaga.

@xNarkon
Copy link

xNarkon commented Oct 25, 2020

@GooRiOn Can you review this? These changes would be handy for me. Also, why Redis persistence is not available through Nuget?

Copy link
Member

@GooRiOn GooRiOn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thx for the effort you put to add EF Core support. However, there are quite a few thing that needs to be changed when it comes to code styling, but also the concept overall. Maybe I miss something but to me the UoW should not be public at all. Feel free to comment on this one!

PS. I promise, next reviews won't take that much time ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants