This repository was archived by the owner on Feb 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
Ef Core support and Sample Web API using Saga with SQL Server #51
Open
UmerIftikhar
wants to merge
8
commits into
snatch-dev:master
Choose a base branch
from
UmerIftikhar:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GooRiOn Can you review this? These changes would be handy for me. Also, why Redis persistence is not available through Nuget? |
GooRiOn
suggested changes
Nov 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thx for the effort you put to add EF Core support. However, there are quite a few thing that needs to be changed when it comes to code styling, but also the concept overall. Maybe I miss something but to me the UoW should not be public at all. Feel free to comment on this one!
PS. I promise, next reviews won't take that much time ;)
src/Chronicle.Integrations.EFCore/Persistence/EFCoreSagaState.cs
Outdated
Show resolved
Hide resolved
src/Chronicle.Integrations.EFCore/Repositories/SagaLogRepository.cs
Outdated
Show resolved
Hide resolved
src/Chronicle.Integrations.EFCore/Repositories/SagaLogRepository.cs
Outdated
Show resolved
Hide resolved
src/Chronicle.Integrations.EFCore/Repositories/SagaStateRepository.cs
Outdated
Show resolved
Hide resolved
src/Chronicle.Integrations.EFCore/Repositories/SagaStateRepository.cs
Outdated
Show resolved
Hide resolved
src/EFCoreTestAppWithChronicleSaga/Handlers/OrderSagaHandler.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
This Pull Request is related to issue no. [6] ([https://github.com//issues/6])
Changes
ISagaLog&ISagaStateRepository.