Skip to content

feat(experimentalIdentityAndAuth): rename IdentityProviderConfig name to ipc #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Nov 14, 2023

Issue #, if available:

N/A.

Description of changes:

Unrelated, TypeScript Test CI fails, fix is in another PR: #1072

Rename IdentityProviderConfig variable name config to ipc since config is already used as a top-level function parameter, e.g.

diff --color -Nur og/src/runtimeConfig.shared.ts new/src/runtimeConfig.shared.ts
--- og/src/runtimeConfig.shared.ts	2023-11-13 19:57:07
+++ new/src/runtimeConfig.shared.ts	2023-11-13 19:57:56
@@ -33,23 +33,23 @@
   httpAuthSchemeProvider: config?.httpAuthSchemeProvider ?? defaultWeatherHttpAuthSchemeProvider,
   httpAuthSchemes: config?.httpAuthSchemes ?? [{
         schemeId: "aws.auth#sigv4",
-        identityProvider: (config: IdentityProviderConfig) =>
-          config.getIdentityProvider("aws.auth#sigv4"),
+        identityProvider: (ipc: IdentityProviderConfig) =>
+          ipc.getIdentityProvider("aws.auth#sigv4"),
         signer: new SigV4Signer(),
       }, {
         schemeId: "smithy.api#httpApiKeyAuth",
-        identityProvider: (config: IdentityProviderConfig) =>
-          config.getIdentityProvider("smithy.api#httpApiKeyAuth"),
+        identityProvider: (ipc: IdentityProviderConfig) =>
+          ipc.getIdentityProvider("smithy.api#httpApiKeyAuth"),
         signer: new HttpApiKeyAuthSigner(),
       }, {
         schemeId: "smithy.api#httpBearerAuth",
-        identityProvider: (config: IdentityProviderConfig) =>
-          config.getIdentityProvider("smithy.api#httpBearerAuth"),
+        identityProvider: (ipc: IdentityProviderConfig) =>
+          ipc.getIdentityProvider("smithy.api#httpBearerAuth"),
         signer: new HttpBearerAuthSigner(),
       }, {
         schemeId: "smithy.api#noAuth",
-        identityProvider: (config: IdentityProviderConfig) =>
-          config.getIdentityProvider("smithy.api#noAuth") || (async () => ({})),
+        identityProvider: (ipc: IdentityProviderConfig) =>
+          ipc.getIdentityProvider("smithy.api#noAuth") || (async () => ({})),
         signer: new NoAuthSigner(),
       }],
   logger: config?.logger ?? new NoOpLogger(),

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall changed the title Rename IdentityProviderConfig name to ipc feat(experimentalIdentityAndAuth): rename IdentityProviderConfig name to ipc Nov 14, 2023
@syall syall marked this pull request as ready for review November 14, 2023 02:32
@syall syall requested review from a team as code owners November 14, 2023 02:32
@syall syall force-pushed the ts-ia-rename-to-ipc branch from 89132b1 to db8e542 Compare November 14, 2023 14:49
@syall syall merged commit b4ff437 into smithy-lang:main Nov 14, 2023
@syall syall deleted the ts-ia-rename-to-ipc branch November 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants