fix: skip unnecessary null checks in equals() methods for generated structures
#1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsNo artifacts changed size |
lauzadis
approved these changes
Jul 30, 2025
0marperez
reviewed
Jul 30, 2025
| .write("if (!#1L.contentEquals(other.#1L)) return false", memberName) | ||
| .closeBlock("} else if (other.#1L != null) return false", memberName) | ||
| } else { | ||
| write("if (!#1L.contentEquals(other.#1L)) return false", memberName) |
Contributor
There was a problem hiding this comment.
Should we be checking the nullability of other.#1L? It's done in the block above
.write("if (other.#1L == null) return false", memberName)
Contributor
Author
There was a problem hiding this comment.
No, we're checking equality between two instances of the same shape. If this.foo cannot be null then other.foo cannot be null either.
| .write("if (!#1L[i].contentEquals(other.#1L[i])) return false", memberName) | ||
| .closeBlock("}") | ||
| .closeBlock("} else if (other.#1L != null) return false", memberName) | ||
| } else { |
0marperez
approved these changes
Jul 30, 2025
| .write("if (!#1L.contentEquals(other.#1L)) return false", memberName) | ||
| .closeBlock("} else if (other.#1L != null) return false", memberName) | ||
| } else { | ||
| write("if (!#1L.contentEquals(other.#1L)) return false", memberName) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
StructureGenerator's equality methods don't check for nullability of member symbols, leading to unnecessary null checks.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.