fix: revert to Dokka1 module paths #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
Affected ArtifactsNo artifacts changed size |
0marperez
approved these changes
Jun 19, 2025
ianbotsf
reviewed
Jun 19, 2025
Comment on lines
+33
to
+36
|
|
||
| dokka { | ||
| modulePath = "aws-credentials" | ||
| } |
There was a problem hiding this comment.
Question: Could we replace all of these per-module declarations with a top-level block instead?
subprojects {
dokka {
modulePath = this@subprojects.name
}
}There was a problem hiding this comment.
Possibly, thanks, I'll take a look at the simplification
There was a problem hiding this comment.
Here is a PR with the simplification, thanks! #1299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve Dokka v1's paths, which are just the module name, rather than the full path to the module.
https://kotlinlang.org/docs/dokka-migration.html#revert-to-the-dgp-v1-directory-behavior
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.