chore: reintegrate E2E smoke tests into the top-level Gradle build; modularize smoke test runners to improve testability #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odularize smoke test runners to improve testability
ianbotsf
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Apr 2, 2025
0marperez
approved these changes
Apr 2, 2025
| } | ||
| indent() | ||
| write(".map { it() }") | ||
| write(".none { !it }") |
Contributor
There was a problem hiding this comment.
Nit: Converting this none into an all would remove the need for negation and make it easier to read:
write(".all { it }")| writer.withBlock("if (!success) {", "}") { | ||
| write("#T(exception)", RuntimeTypes.Core.SmokeTests.printExceptionStackTrace) | ||
| write("exitCode = 1") | ||
| write("printer.appendLine(exception.stackTraceToString().prependIndent(#S))", "#") |
Contributor
There was a problem hiding this comment.
Style/Suggestion: "# " with a space after # to slightly improve readability
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
This change modularizes smoke test runners to improve their testability so that the E2E smoke tests can be refactored in aws-sdk-kotlin to run inside the top-level Gradle build.
Companion PR: aws/aws-sdk-kotlin#1558
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.