fix: correctly handle sequential calls to SingleFlightGroup
#1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Feb 28, 2025
| assertEquals("Foo", first) | ||
|
|
||
| val second = group.singleFlight { "Bar" } | ||
| assertEquals("Bar", second) // Fails; second == "Foo" |
Contributor
There was a problem hiding this comment.
nit: Stray comment? This command no longer fails
Contributor
Author
There was a problem hiding this comment.
Yep forgot to remove that.
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsChanged in size
|
0marperez
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Fixes a bug that caused subsequent invocations of
SingleFlightGroup.singleFlightto reuse previously-completed jobs even when they'd completed before the subsequent call began.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.