misc: test union member name same as union #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Feb 13, 2025
Comment on lines
+228
to
+229
| @Test | ||
| fun `it compiles models with unions with members that have the same name as the union`() { |
There was a problem hiding this comment.
docs: add a comment with the original GitHub issue that inspired this test case
Affected ArtifactsNo artifacts changed size |
ianbotsf
approved these changes
Feb 13, 2025
lauzadis
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
closes #1129
Description of changes
Adds a test to make sure we don't regress.
See: aws/aws-sdk-kotlin#1526
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.