kn: observability #1234
Merged
kn: observability #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
commented
Feb 4, 2025
| } | ||
|
|
||
| named("jvmTest") { | ||
| findByName("jvmTest")?.run { |
Contributor
Author
There was a problem hiding this comment.
note: this change was necessary because the new logging-crt module does not have a JVM source set, causing errors like "jvmTest does not exist"
This comment has been minimized.
This comment has been minimized.
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsChanged in size
|
0marperez
reviewed
Mar 19, 2025
| public class CrtLogger(public val name: String, public val config: CrtConfig) : | ||
| WithCrt(), | ||
| Logger { | ||
| override fun trace(t: Throwable?, msg: MessageSupplier): Unit = log(CrtLogLevel.Trace, msg()) |
Contributor
There was a problem hiding this comment.
Question: Can we pass in the t to the crt log function?
Contributor
Author
There was a problem hiding this comment.
No, we can't. This is invoking a CRT function AWS_LOGF which has no concept of exceptions / throwables
| } | ||
|
|
||
| // CRT logger does not support setting key-value pairs | ||
| override fun setKeyValuePair(key: String, value: Any) { } |
Contributor
There was a problem hiding this comment.
Question: Is this not supported yet or are there no plans to support it?
Contributor
Author
There was a problem hiding this comment.
No plans to support it
0marperez
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.