Skip to content

Conversation

@roomote
Copy link

@roomote roomote bot commented Nov 15, 2025

This PR adds comprehensive documentation explaining the Issue First approach for contributing to the Smartsheet Python SDK, specifically tailored for use with Roo Code Cloud Agents.

Changes

  • Added Issue First.md file with detailed explanation of the Issue First methodology
  • Adapted content from Roo Code Cloud documentation to Smartsheet Python SDK context
  • Included best practices for writing issues that work effectively with Cloud Agents
  • Provided concrete examples of bug reports, feature requests, and documentation issues
  • Explained how Cloud Agents use GitHub Issues as prompts to generate high-quality code changes

Why This Matters

With Roo Code Cloud integration enabled for this repository, contributors can now leverage AI-powered Cloud Agents to help implement changes. A well-written GitHub Issue serves as a high-quality prompt that gives Cloud Agents the context needed to:

  • Understand the problem or feature request
  • Identify which parts of the SDK codebase need modification
  • Generate appropriate Python code following SDK patterns
  • Create comprehensive tests and documentation

Documentation Structure

The new documentation covers:

  1. What is Issue First - Core concept explanation
  2. Why It Matters for Cloud Agents - Benefits and importance
  3. How to Use Issue First with Cloud Agents - Step-by-step workflow
  4. Best Practices - Guidelines for writing effective issues
  5. Examples - Real-world examples of well-written issues

This documentation will help both human contributors and Cloud Agents work more effectively together to improve the Smartsheet Python SDK.

- Add comprehensive Issue First.md explaining the Issue First approach
- Adapt Roo Code Cloud documentation for Smartsheet Python SDK context
- Include best practices for writing issues that work well with Cloud Agents
- Provide examples of bug reports, feature requests, and documentation issues
- Explain how Cloud Agents use issues as prompts to generate code changes
@roomote
Copy link
Author

roomote bot commented Nov 15, 2025

Rooviewer Clock   See task on Roo Cloud

Reviewed commit 1411a18. Latest changes are markdown linting fixes only. All previously flagged issues have been resolved.

  • Filename uses space instead of hyphen/underscore (inconsistent with existing docs)
  • Workflow conflicts with existing CONTRIBUTING.md guidance
  • New documentation not referenced in README.md or CONTRIBUTING.md
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@@ -0,0 +1,296 @@
# Issue First Approach for Smartsheet Python SDK
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename Issue First.md uses a space, which is inconsistent with the repository's documentation naming convention. All other documentation files use hyphens or are single words (e.g., README.md, CONTRIBUTING.md, ADVANCED.md). Consider renaming to ISSUE-FIRST.md or ISSUE_FIRST.md for consistency and to avoid potential issues with tools that don't handle spaces in filenames well.

Fix it with Roo Code or mention @roomote and request a fix.

Comment on lines +3 to +5
## What is "Issue First"?

The "Issue First" approach is a collaborative development methodology where **all contributions to the Smartsheet Python SDK must begin with a GitHub Issue** before any code changes are made. This means that whether you're fixing a bug, adding a new feature, or improving documentation, you first create or identify an existing issue that describes what needs to be done.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document introduces an "Issue First" workflow that conflicts with the existing guidance in CONTRIBUTING.md. The current CONTRIBUTING.md states "Did you write a patch that fixes a bug? Open a new GitHub pull request with the patch," which suggests a code-first approach. This creates contradictory guidance for contributors. Consider either updating CONTRIBUTING.md to align with the Issue First approach or adding a clear statement in this document acknowledging the relationship between the two workflows.

Fix it with Roo Code or mention @roomote and request a fix.

@@ -0,0 +1,296 @@
# Issue First Approach for Smartsheet Python SDK
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new documentation file is not referenced anywhere in the existing documentation, making it difficult for contributors to discover. Consider adding a reference to this file in README.md (in the Documentation section) and in CONTRIBUTING.md (to explain the workflow). Without these links, contributors may not be aware of the Issue First approach or how to work with Cloud Agents.

Fix it with Roo Code or mention @roomote and request a fix.

@roomote
Copy link
Author

roomote bot commented Nov 15, 2025

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issue. Renamed the file to follow repository naming conventions.

View commit | Revert commit

@roomote
Copy link
Author

roomote bot commented Nov 15, 2025

Fixaroo Clock   See task on Roo Cloud

Fixed the reported issues. All local checks passed.

View commit | Revert commit

…uidelines

- Update CONTRIBUTING.md to require issues before all contributions
- Add Issue First reference to README.md Contributing section
- Resolve workflow conflicts between direct PRs and Issue First approach
@Smartsheet-JB-Brown
Copy link

@roomote there appears to be a number of linting issues in the new Issue-First.md as reported by github's linting check. Fix them.

@roomote
Copy link
Author

roomote bot commented Nov 15, 2025

Fixaroo Clock   See task on Roo Cloud

Fixed all markdown linting issues in ISSUE-FIRST.md.

View commit | Revert commit

@smartsheet smartsheet deleted a comment from roomote bot Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants