Ensure proper binding for dynamically generated functions. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many places in numeric.js create new functions using the Function(...) constructor. Such functions do not have access to the local scope. Therefore they bind to the global "numeric" object, which might not exist, or might belong to a different version of numeric.js, or might be something different altogether. Since we are careful enough to have a local variable in most places, it appears prudent to make sure that we pass this to functions created from source strings as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places in numeric.js create new functions using the Function(...)
constructor. Such functions do not have access to the local scope.
Therefore they bind to the global "numeric" object, which might not exist,
or might belong to a different version of numeric.js, or might be something
different altogether. Since we are careful enough to have a local variable
in most places, it appears prudent to make sure that we pass this to
functions created from source strings as well.
The code is untested so far.