Skip to content

fix: Implement flush function on Async #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Implement flush function on Async #36

wants to merge 1 commit into from

Conversation

gabyx
Copy link

@gabyx gabyx commented Mar 16, 2024 •
edited
Loading

@gabyx
Copy link
Author

gabyx commented Mar 16, 2024

Not really sure if that feature is needed: The use case was #35 :

  • Make the worker thread somehow stop processing records (not implemented)
  • Flush all pending stuff (till the crossbeam channels are empty) implemented
  • Output some prompt on letssay stderr.
  • Make the worker thread continue to process records.

So if we would have a term logger we could before prompting just use log.flush(...) and then show the prompt and wait for input etc...

@dpc
Copy link
Contributor

dpc commented Mar 17, 2024

Looks reasonable to me. Ping @Techcable as current maintainer.

Techcable added a commit to Techcable/slog-async that referenced this pull request Aug 9, 2025
@Techcable
Implement the Drain::flush method
7e7c53d 
Sends a message to the logging thread,
then blocks until the logger acknowledges it.
Contrast this to the busy-loop approach in slog-rs#36

Pinned to the branch used in PR #349,
so cannot be released until that PR is accepted.

Fixes issue slog-rs#35
Techcable added a commit to Techcable/slog-async that referenced this pull request Aug 9, 2025
@Techcable
Implement the Drain::flush method
9392bcf 
Sends a message to the logging thread,
then blocks until the logger acknowledges it.
Contrast this to the busy-loop approach in slog-rs#36

Pinned to the branch used in PR #349,
so cannot be released until that PR is accepted.

Fixes issue slog-rs#35
@Techcable Techcable mentioned this pull request Aug 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabyx @dpc