This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Private API Deprecation #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 6, 2016 02:20
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of not using any private API in this project, we are disabling a few features until a public API is available.
Keyboard Panning
Because the keyboard is on its own view hierarchy since iOS 9, we needed to lookup for its view so we can move the text input whenever its origin changed. iOS 9 users won't be able to move the keyboard with the gesture anymore, even if the
keyboardPanningEnabledis enabled. It will still work in iOS 7 and 8.Magnifying Glass Detection
Whenever a user activates the magnifying glass by long pressing on the text content area and moves the cursor into a range of text that requires auto-completion, the magnifying glass would disappear all of the sudden, causing erratic UI behaviours. Why, you say? Because we need to reload the textView and disable auto-correction since it overrides any auto-completion while typing.
From now, the
isLoupeVisibleflag will always be false. These erratic behavior will be back again, in any version of iOS.The code using private APIs is still available in this project's source code, but commented out. Use it at your own risk.
We have filed a radar proposing new APIs to be added in
UITextInputTraitsto help making the keyboard experience better.http://openradar.appspot.com/radar?id=5021485877952512