CI: Unbreak Eigen #242
Closed
CI: Unbreak Eigen #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eigen 3.3+ changed their internal BLAS build logic, which will need a deeper look why it does not work. Just setting the flag to build BLAS is overwritten by other logic with the Fortran compiler, which breaks current CI.
Author
|
@sizmailov this should unbreak CI :) Can you approve my runners pls? |
Remove outdated, add new.
Author
|
Also happy to merge #243 instead of mine :) |
Owner
|
Superseded by #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eigen 3.3+ changed their internal BLAS build logic, which will need a deeper look why it does not work. Just setting the flag to build BLAS is overwritten by other logic with the Fortran compiler, which breaks current CI.
This should unbreak CI. A follow-up could look into the 3.3+ and again changing logic of 3.4+ of Eigen3: https://gitlab.com/libeigen/eigen/-/blob/master/CMakeLists.txt