Tests: fix namespace #164
Merged
Tests: fix namespace #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes 162
|
Thanks!
That's actually been something I wanted to do for a while, which was how I did it for https://github.com/sirbrillig/phpcs-import-detection/ That said, if this is a quicker fix, I'm happy to merge it and we can move things around in another PR. What do you think? |
|
I'm going to merge this for completeness, and also make a PR to move the tests. |
sirbrillig
pushed a commit
that referenced
this pull request
May 25, 2020
Closes 162 Co-authored-by: jrfnl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
Note: alternatively the choice could be made to move the
Testsdirectory out of theVariableAnalysisdirectory as, as this standard doesn't use the PHPCS native test framework, there is no need for the tests to be in the same directory as the application files.