Skip to content

fix: invalid signature error #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: invalid signature error #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34bbe3c
fix: invalid signature error
kakopappa Jan 17, 2025
5f1f759
fix: typo
kakopappa Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Version 3.4.1
New:
- Fix: invalid signature error message.

## Version 3.4.0
New:
- Support Image upload on camera devices
Expand Down
2 changes: 1 addition & 1 deletion library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"maintainer": true
}
],
"version": "3.4.0",
"version": "3.4.1",
"frameworks": "arduino",
"platforms": [
"espressif8266",
Expand Down
2 changes: 1 addition & 1 deletion library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=SinricPro
version=3.4.0
version=3.4.1
author=Boris Jaeger <[email protected]>
maintainer=Boris Jaeger <[email protected]>
sentence=Library for https://sinric.pro - simple way to connect your device to alexa
Expand Down
22 changes: 19 additions & 3 deletions src/SinricPro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ class SinricProClass : public SinricProInterface {
void handleDeviceRequest(JsonDocument& requestMessage, interface_t Interface);
void handleModuleRequest(JsonDocument& requestMessage, interface_t Interface);
void handleResponse(JsonDocument& responseMessage);
void handleInvalidSignatureRequest(JsonDocument& requestMessage, interface_t Interface);

JsonDocument prepareRequest(String deviceId, const char* action);

Expand Down Expand Up @@ -327,7 +328,7 @@ void SinricProClass::handleResponse(JsonDocument& responseMessage) {
}

void SinricProClass::handleModuleRequest(JsonDocument& requestMessage, interface_t Interface) {
DEBUG_SINRIC("[SinricPro.handleModuleScopeRequest()]: handling device sope request\r\n");
DEBUG_SINRIC("[SinricPro.handleModuleScopeRequest()]: handling module scope request\r\n");
#ifndef NODEBUG_SINRIC
serializeJsonPretty(requestMessage, DEBUG_ESP_PORT);
#endif
Expand Down Expand Up @@ -434,13 +435,28 @@ void SinricProClass::handleReceiveQueue() {
}
};
} else {
DEBUG_SINRIC("[SinricPro.handleReceiveQueue()]: Signature is invalid! \r\n");
if (messageType == FSTR_SINRICPRO_request) handleDeviceRequest(jsonMessage, rawMessage->getInterface());
handleInvalidSignatureRequest(jsonMessage, rawMessage->getInterface());
}
delete rawMessage;
}
}

void SinricProClass::handleInvalidSignatureRequest(JsonDocument& requestMessage, interface_t Interface) {
DEBUG_SINRIC("[SinricPro.handleInvalidSignatureRequest()]: Signature is invalid!\r\n");

#ifndef NODEBUG_SINRIC
serializeJsonPretty(requestMessage, DEBUG_ESP_PORT);
#endif

JsonDocument responseMessage = prepareResponse(requestMessage);
responseMessage[FSTR_SINRICPRO_payload][FSTR_SINRICPRO_success] = false;
responseMessage[FSTR_SINRICPRO_payload][FSTR_SINRICPRO_message] = "Signature is invalid";

String responseString;
serializeJson(responseMessage, responseString);
sendQueue.push(new SinricProMessage(Interface, responseString.c_str()));
}

void SinricProClass::handleSendQueue() {
if (!isConnected()) return;
if (!timestamp.getTimestamp()) return;
Expand Down
2 changes: 1 addition & 1 deletion src/SinricProVersion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Version Configuration
#define SINRICPRO_VERSION_MAJOR 3
#define SINRICPRO_VERSION_MINOR 4
#define SINRICPRO_VERSION_REVISION 0
#define SINRICPRO_VERSION_REVISION 1
#define SINRICPRO_VERSION STR(SINRICPRO_VERSION_MAJOR) "." STR(SINRICPRO_VERSION_MINOR) "." STR(SINRICPRO_VERSION_REVISION)
#define SINRICPRO_VERSION_STR "SinricPro (v" SINRICPRO_VERSION ")"
#define SINRICPRO_VERISON_INT SINRICPRO_VERSION_MAJOR * 1000000 + SINRICPRO_VERSION_MINOR * 1000 + SINRICPRO_VERSION_REVISION
Loading