-
Notifications
You must be signed in to change notification settings - Fork 22
Add MODEL START and MODEL STOP fusion commands #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
258da89 to
0637237
Compare
|
@mohit-singlestore You'll need to run the pre-commit checks as described in https://github.com/singlestore-labs/singlestoredb-python/blob/main/CONTRIBUTING.md for the checks to pass. |
| if self._manager is None: | ||
| raise ManagementError(msg='Manager not initialized') | ||
| res = self._manager._post(f'inferenceapis/{self.project_id}/{model_name}/start') | ||
| return res.json() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious as to what sort of information is returned here. Should it be some sort of ModelStatus object returned instead of a raw decoded json object? If there is something relevant returned, it might be a good idea to create a result object in the Fusion SQL START / STOP commands that returns that information as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response includes modelName, modelID, hostingPlatform, and status. I've updated it to return a proper result object instead of raw JSON. Please take a look.
06c0a7c to
eb31853
Compare
This PR adds 2 new fusion commands for models