Skip to content

Conversation

@dmosorast
Copy link
Contributor

@dmosorast dmosorast commented Oct 22, 2019

Description of change

https://stitchdata.atlassian.net/browse/SUP-895

For data types of int8[] that get reported by postgres as bigint[] into the metadata's sql-datatype field, log-based was incorrectly typing them as String during the data type conversion lookup. The schema still has integer for these columns, it's just that the records don't match once emitted.

This PR fixes that by adding a case for bigint[] and preventing the fallback to text[].

QA steps

  • automated tests passing
    • Added this case to the integration test
  • manual qa steps passing (list below)
    • Confirmed with a manual sync and breakpoint that adding this clause fixes the datatype for the intended column type

Risks

Low, this is an additive change.

Rollback steps

  • revert this branch

@dmosorast dmosorast merged commit b551aab into master Oct 23, 2019
@dmosorast dmosorast deleted the fix/log-based-bigint-array branch October 23, 2019 17:25
@dmosorast dmosorast mentioned this pull request Oct 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants