Skip to content

Fix circleci #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Fix circleci #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd73659
Fix locale issues
luandy64 Jul 31, 2019
c0c02aa
Change variable name to not override a module name to make pylint happy
luandy64 Jul 31, 2019
362b803
Revert the addition of the catalog flag
luandy64 Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
command: |
aws s3 cp s3://com-stitchdata-dev-deployment-assets/environments/tap-tester/sandbox dev_env.sh
source dev_env.sh
export LC_ALL=C
python3 -m venv /usr/local/share/virtualenvs/tap-postgres
source /usr/local/share/virtualenvs/tap-postgres/bin/activate
pip install .
Expand Down
4 changes: 2 additions & 2 deletions tap_postgres/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,9 +691,9 @@ def main_impl():

if args.discover:
do_discovery(conn_config)
elif args.properties or args.catalog:
elif args.properties:
state = args.state
do_sync(conn_config, args.catalog.to_dict() if args.catalog else args.properties, args.config.get('default_replication_method'), state)
do_sync(conn_config, args.properties, args.config.get('default_replication_method'), state)
else:
LOGGER.info("No properties were selected")

Expand Down
4 changes: 2 additions & 2 deletions tap_postgres/sync_strategies/logical_replication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ def create_array_elem(elem, sql_datatype, conn_info):
#custom datatypes like enums
cast_datatype = 'text[]'

sql = """SELECT $stitch_quote${}$stitch_quote$::{}""".format(elem, cast_datatype)
cur.execute(sql)
sql_stmt = """SELECT $stitch_quote${}$stitch_quote$::{}""".format(elem, cast_datatype)
cur.execute(sql_stmt)
res = cur.fetchone()[0]
return res

Expand Down