Skip to content

Escape string in hstore value #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Escape string in hstore value #59

merged 1 commit into from
Jul 23, 2019

Conversation

@drdee
Copy link
Contributor

@drdee drdee commented Jul 5, 2019

This PR fixes #57

I added the function create_hstore_elem_query to make it easy to add a unit-test without having to stub. Hope that's cool. I am also assuming that elem is a string.

@drdee
Copy link
Contributor Author

drdee commented Jul 5, 2019

@psantacl @luandy64 -- please have a look.

@cmerrick
Copy link

cmerrick commented Jul 15, 2019

Fixes #57

dmosorast
dmosorast approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@dmosorast dmosorast merged commit 48d05f2 into singer-io:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hstore_to_array() does not escape single quotes in value

3 participants

@drdee @cmerrick @dmosorast